fix: Buyer guarantee refactor QA fixes #8440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-rs
commented
Sep 21, 2021
Comment on lines
+14
to
+24
| interface ConditionalWrapperProps { | ||
| condition: boolean | ||
| wrapper: (children: React.ReactElement) => JSX.Element | ||
| children: React.ReactElement | ||
| } | ||
|
|
||
| const ConditionalWrapper: React.FC<ConditionalWrapperProps> = ({ | ||
| condition, | ||
| wrapper, | ||
| children, | ||
| }) => (condition ? wrapper(children) : children) |
There was a problem hiding this comment.
Conditional wrapper to avoid duplicate code
jo-rs
commented
Sep 21, 2021
| @@ -75,10 +75,10 @@ export const BuyerGuaranteeIndex: React.FC = () => { | |||
| } | |||
|
|
|||
| const learnMoreButton = (width?: string) => ( | |||
| <RouterLink to={supportArticleURL} target="_blank"> | |||
| <RouterLink noUnderline to={supportArticleURL} target="_blank"> | |||
jo-rs
commented
Sep 21, 2021
| <Button | ||
| width={width ? width : ["100%", "80%", "50%"]} | ||
| variant="secondaryOutline" | ||
| variant={isMobile ? "secondaryOutline" : "primaryBlack"} |
There was a problem hiding this comment.
Filled in CTA for desktop
jo-rs
commented
Sep 21, 2021
| @@ -229,7 +229,7 @@ export const BuyerGuaranteeIndex: React.FC = () => { | |||
| </Flex> | |||
| </Flex> | |||
| {/* Artsy Guarantee Sections desktop */} | |||
| <GridColumns gridColumnGap={4} gridRowGap={[6, 12]} my={[6, 12]}> | |||
| <GridColumns gridColumnGap={[0, 4]} gridRowGap={[6, 12]} my={[6, 12]}> | |||
There was a problem hiding this comment.
Addresses responsive cropping
jo-rs
commented
Sep 21, 2021
| inline | ||
| variant="noOutline" | ||
| onClick={onClick} | ||
| style={{ whiteSpace: "pre-wrap" }} |
There was a problem hiding this comment.
Bonus: addresses links not wrapping and overlapping on smaller screens
rquartararo
approved these changes
Sep 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses visual QA issues from PURCHASE-2918
Missing image caption on small screens: it seems to be purposefully engineered this way from the top-level component ❌
Mobile links not working ✅
cc: @artsy/purchase-devs